Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging cells right / left might provide to broken layout #3192

Closed
jodator opened this issue Jun 12, 2018 · 8 comments
Closed

Merging cells right / left might provide to broken layout #3192

jodator opened this issue Jun 12, 2018 · 8 comments
Labels
package:table resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Jun 12, 2018

screencast 2018-06-12 14_43_02

The above actions will produce such table:

<table>
    <tr>
        <td>a</td>
        <td colspan="2">bc</td>
    </tr>
    <tr>
        <td colspan="2">ab</td>
        <td>c</td>
    </tr>
</table>

which is rendered as:

selection_006

I don't really know if this issue is important or easy to fix.

@Reinmar
Copy link
Member

Reinmar commented Jun 12, 2018

This is funny. I guess that the "merge left" option should not be enabled. It allows breaking the table layout so it should be disabled.

@jodator
Copy link
Contributor Author

jodator commented Jun 12, 2018

This is funny. I guess that the "merge left" option should not be enabled. It allows breaking the table layout so it should be disabled.

Yeah... but the tricky part is how to detect such case?

@Reinmar
Copy link
Member

Reinmar commented Jun 12, 2018

You know the layout of the table. So you can also predict what applying this command will cause to it. Am I right?

@jodator
Copy link
Contributor Author

jodator commented Jun 12, 2018

You know the layout of the table. So you can also predict what applying this command will cause to it. Am I right?

Right now it seems to me that you'd have to check some special case of missing column (the table should have 3 columns) but this one has 2 cells in each row (as I'm writing it - maybe it is not such complex case after all...) and with rows it is straight forward as table cells are child of tableRow element. For columns we have to guess...

@jodator
Copy link
Contributor Author

jodator commented Jun 13, 2018

ps.: similar thing happens in CKEditor 4

@jodator jodator assigned jodator and unassigned jodator Jun 21, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
@jodator
Copy link
Contributor Author

jodator commented May 26, 2020

Might get fixed by: #6609.

@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 3, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants