Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default font size configuration (class based) does not work with supportAllValues #6550

Closed
Reinmar opened this issue Apr 3, 2020 · 0 comments Β· Fixed by ckeditor/ckeditor5-font#62
Assignees
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 3, 2020

πŸ“ Provide detailed reproduction steps (if any)

It's applied as an inline style:

While it should apply a class.

It's a tricky case – some values must apply classes and some should apply inline styles (pasted content). Therefore, we can say that supportAllValues works only with inline value based config. In this case, we need an error thrown when one tries to use supportAllValues without setting available items and we need to cover this in the documentation.


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. package:font labels Apr 3, 2020
@Reinmar Reinmar added this to the iteration 31 milestone Apr 3, 2020
Reinmar added a commit to ckeditor/ckeditor5-font that referenced this issue Apr 21, 2020
Internal: The FontSize plugin requires numerical values in the configuration (as options) if fontSize.supportAllValues was set on true. Closes ckeditor/ckeditor5#6550.
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: The FontSize plugin requires numerical values in the configuration (as options) if fontSize.supportAllValues was set on true. Closes #6550.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants