This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
fontSize.supportAllValues=true requires numerical values in configuration #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
added a commit
to ckeditor/ckeditor5-paste-from-office
that referenced
this pull request
Apr 21, 2020
Docs: Use numerical values as options in font size dropdown when fontSize.supportAllValues=true. See ckeditor/ckeditor5-font#62
mlewand
pushed a commit
to ckeditor/ckeditor5
that referenced
this pull request
May 1, 2020
Docs: Use numerical values as options in font size dropdown when fontSize.supportAllValues=true. See ckeditor/ckeditor5-font#62
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: The FontSize plugin requires numerical values in the configuration (as
options) iffontSize.supportAllValueswas set ontrue. Closes ckeditor/ckeditor5#6550.Additional information
Not sure about the prefix. Fix or Internal (because the change fixes a bug "introduced" in the same iteration).