Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial table insert dropdown render time could be improved #6341

Closed
mlewand opened this issue Feb 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#255
Closed

Initial table insert dropdown render time could be improved #6341

mlewand opened this issue Feb 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#255
Assignees
@mlewand
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Milestone
iteration 31 (v19...

Comments

@mlewand
Copy link
Contributor

mlewand commented Feb 27, 2020

📝 Provide a description of the improvement

Render time can be reduced if we initialize table's grid all at once, instead adding it one by one as we do it today.

See the research here: #6194

This issue requires #6319 to be implemented correctly.

📃 Other details

  • Browser: Any
  • OS: Any

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:table type:performance This issue reports a performance issue or a possible performance improvement. labels Feb 27, 2020
@mlewand mlewand added this to the iteration 30 milestone Feb 27, 2020
@mlewand mlewand self-assigned this Feb 27, 2020
@mlewand mlewand mentioned this issue Feb 27, 2020
Merged
@Reinmar Reinmar modified the milestones: iteration 30, iteration 31 Mar 10, 2020
@mlewand mlewand mentioned this issue Mar 23, 2020
Closed
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 6, 2020
@oleq
Merge pull request #255 from ckeditor/i/6341
fd1d5da 
Other: Reduced the table insertion grid rendering time. Closes ckeditor/ckeditor5#6341.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #255 from ckeditor/i/6341
6d5bc3c 
Other: Reduced the table insertion grid rendering time. Closes #6341.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

Reduced the initial table insertion dropdown render time ckeditor/ckeditor5-table
2 participants
@Reinmar @mlewand