Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and change order of params in Batch attribute methods #255

Closed
szymonkups opened this issue Jul 21, 2016 · 0 comments
Closed

Rename and change order of params in Batch attribute methods #255

szymonkups opened this issue Jul 21, 2016 · 0 comments
Assignees
@szymonkups
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 2

Comments

@szymonkups
Copy link
Contributor

After fixing ckeditor5-engine#482 and ckeditor5-engine#156 name and order of arguments of engine.model.Batch#setAttr and engine.model.Batch#removeAttr methods will change. These methods are used by ckeditor5.command.AttributeCommand.
@szymonkups szymonkups added this to the iteration 2 milestone Jul 21, 2016
@szymonkups szymonkups self-assigned this Jul 21, 2016
This was referenced Jul 21, 2016
Merged
Merged
@Reinmar Reinmar added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Jul 21, 2016
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #255 from ckeditor/i/6341
6d5bc3c 
Other: Reduced the table insertion grid rendering time. Closes #6341.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 2
Development

No branches or pull requests
2 participants
@Reinmar @szymonkups