Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance manual tests for table selection #6306

Closed
jodator opened this issue Feb 21, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#251
Closed

Enhance manual tests for table selection #6306

jodator opened this issue Feb 21, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#251
Assignees
@jodator
Labels
package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 30 (v18...

Comments

@jodator
Copy link
Contributor

jodator commented Feb 21, 2020

Provide a description of the task

So the table selection introduces a new set of issues and strongly depends on the content surrounding the table.

@oleq proposed enhancements to the current manual test. But I think that we might have more cases (upcoming copy-paste integration).

My proposition is to have one sample for both (one editor and paste target) like in the image below. To test various cases we could introduce buttons with fixtures for those cases (single table, complex table, table with block content, table with paragraphs surrounding the table).
@jodator jodator added type:task This issue reports a chore (non-production change) and other types of "todos". package:table labels Feb 21, 2020
@jodator jodator added this to the iteration 30 milestone Feb 21, 2020
@jodator jodator mentioned this issue Feb 21, 2020
Merged
@jodator jodator mentioned this issue Feb 24, 2020
Merged
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 24, 2020
@oleq
Merge pull request #251 from ckeditor/i/6306
5897334 
Tests: Improved the content of table selection and clipboard manual tests. Closes ckeditor/ckeditor5#6306.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

I/6306 ckeditor/ckeditor5-table
1 participant
@jodator