I/6113: Base table selection plugin #230

jodator · 2020-01-29T12:00:03Z

Suggested merge commit message (convention)

Feature: Introduce TableSelection plugin. Closes ckeditor/ckeditor5#6113.

Additional information

🎉 a TableSelection has matured since its first commit in August of 2018.
most important things here are: TableSelection plugin itself and the introduced MouseSelectionHandler - the architecture of this feature is meant to have keyboard handler in a similar fashion
the conversion uses the highlight mechanism known from the widget (fake selection, etc)
if something is not working or not implemented - check the epick first if it is not reported - this PR only enables table selection with a mouse - there are no commands that would support this ATM

This reverts commit aa398a9

# Conflicts: # src/commands/mergecellcommand.js # src/tableui.js # tests/converters/downcast.js

# Conflicts: # src/commands/mergecellcommand.js

jodator · 2020-02-18T12:07:14Z

@Reinmar so for the bugs:

Fixed on PR
Moved to UI/UX issue - it is a Chrome issue IMO as on FF it works OK

As for the missing features:

somehow fixed on PR
added a comment in the keyboard selection issue
I've created a bug for this at this needs some time to debug implement. There's a starting point though. Table selection does not cooporate with typing ckeditor5#6284

oleq

Mostly docs. Some minor changes.

I'll create a separate review for more because in the past GitHub failed when there were more than 50 suggestions and... I learned my lesson.

src/tableselection/converters.js

theme/tableediting.css

src/commands/removerowcommand.js

src/tableselection.js

src/tableselection/mouseeventsobserver.js

oleq

Mostly docs. Some minor changes.

I'll create a separate review for more because in the past GitHub failed when there were more than 50 suggestions and... I learned my lesson.

oleq

Mostly minor issues.

src/tableselection/mouseselectionhandler.js

tests/_utils/utils.js

oleq · 2020-02-20T15:10:51Z

tests/manual/tableselection.html

+</style>
+
+<div id="editor">
+	<p>A table to test selection:</p>


This test's content is too homogenous to properly test the feature (as follow-ups has shown). We need more cases, for instance:

with the content before and after the table,

with a solitary table in the content,

with a table that has some cells already split/merged,

with a table that has links, block quotes and other content in some cells.

I have something already for some of the points in the copy table fragment PR. I can cherry pick it here.

But I'm not sure how to handle all these issues in one manual test. I've added only a complex table (which covers two of those issues).

Create 2 editors? 😛

But we have 4 or more cases :P

But what do you think about loading fixtures on a button? One editor (I'd like to have one editor as copy-paste manual tests enhancement would require an editiable arae side by side to the editor.

Moved to: ckeditor/ckeditor5#6306

Co-Authored-By: Aleksander Nowodzinski <[email protected]>

oleq · 2020-02-20T16:30:33Z

Post-review follow-ups:

Selected table cells need a solid background ckeditor5#6302 (lack of background for selected cells)
Multiple cell selection does not get along with enter ckeditor5#6301 (enter and backspace issues)
Multiple cell selection renders after the editor if there is some content ckeditor5#6300 (selection is spilling out)
Multiple cell selection is (sometimes) lost when it ends beyond the table ckeditor5#6299 (selection lost if goes beyond the editor)

# Conflicts: # src/commands/utils.js

jodator added 30 commits September 6, 2018 14:45

Added: Fake table selection POC.

6f5947a

Changed: Make stopSelection work when mouse move outside the table.

9f56ac6

Changed: Do not change tables in table selection mode.

4a5e8f7

Changed: Extract TableSelection class.

631c6ba

Changed: Remove superfluous selection modes from TableSelection.

b46b9c7

Changed. Make TableSelection a plugin.

fc6401e

Tests: Stub TableSelection tests.

7d1aaa9

Fix missing method reference.

cb97f1a

Add some tests for TableSelection.

ead7f98

Add tests for TableSelection class methods.

8cc27ce

Add tests for TableSelection view selection.

17086a1

Add MergeCellsCommand.

922bfa2

Tests: Fix table test dependencies.

843eb92

Tests: Simplify table manual test data and add model output.

aa398a9

Make tableCell an object.

c4572a9

MergeCellCommand should update selection before removing table cells.

33ef296

Remove directional merge cell command.

967c136

Update merge cell command to support ranges not table selection plugin.

2042317

Fix table commands after changes in selection mode.

41ae8f5

Test: Add table selection tests in table editing.

15b3a8e

Revert "Tests: Simplify table manual test data and add model output."

263a53a

This reverts commit aa398a9

Tests: Add manual test for table selection.

3f2dc7f

WiP: Refactor TableSelection to an Observer.

8fe81c2

Merge branch 'master' into t/63

43104d3

Update code to the latest engine API.

6a7bbea

Merge branch 'master' into t/63

6b53ca3

Fix table selection manual test.

72adea1

Merge branch 'master' into t/63

fe04ea0

# Conflicts: # src/commands/mergecellcommand.js # src/tableui.js # tests/converters/downcast.js

Merge branch 'master' into i/3202

bbc3cdf

# Conflicts: # src/commands/mergecellcommand.js

Update manual tests data.

b320675

jodator added 4 commits February 17, 2020 19:27

Update TableSelection logic after fixes in MouseSelectionHandler.

0e01c3f

Rename tests for MouseSelectionHandler.

d497866

TableSelection should be cleared on external selection change.

2f1a9dc

Extract assertSelectedCells() common test util function.

7619a77

jodator mentioned this pull request Feb 18, 2020

Table mouse selection UI/UX ckeditor/ckeditor5#6114

Closed

2 tasks

jodator force-pushed the i/6113 branch from 684d1fa to 7619a77 Compare February 18, 2020 12:12

oleq self-requested a review February 19, 2020 14:02

jodator mentioned this pull request Feb 20, 2020

I/6118: Copy selected table fragment. #250

Merged

oleq suggested changes Feb 20, 2020

View reviewed changes

jodator and others added 13 commits February 20, 2020 16:29

Apply suggestions from code review.

3a2e025

Co-Authored-By: Aleksander Nowodzinski <[email protected]>

Update src/commands/removerowcommand.js PR suggestions.

cf6583d

Co-Authored-By: Aleksander Nowodzinski <[email protected]>

Apply suggestions from code review

bb8cd22

Co-Authored-By: Aleksander Nowodzinski <[email protected]>

Improve TableSelection docs.

e4cfc97

Use standard library for basic mathematical operations.

1eae916

Remove duplicated Observable mixin.

f7f3902

Update src/tableselection/mouseselectionhandler.js

9e87cc8

Co-Authored-By: Aleksander Nowodzinski <[email protected]>

Move selection visual styles to tableselection.css.

34df24d

Bring back table selection styles.

27ce442

And use proper CSS class for a selected table cell.

4c3c317

Fix tests after changing CSS class for selected table cell.

bd67fc9

Add missing the.

c01394b

Add complex table to the table selection manual test.

9133349

jodator requested a review from oleq February 20, 2020 16:41

Merge branch 'table-selection' into i/6113

2ba138c

# Conflicts: # src/commands/utils.js

oleq merged commit 281dba5 into table-selection Feb 21, 2020

jodator mentioned this pull request Feb 21, 2020

Enhance manual tests for table selection ckeditor/ckeditor5#6306

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I/6113: Base table selection plugin #230

I/6113: Base table selection plugin #230

jodator commented Jan 29, 2020 •

edited

Loading

jodator commented Feb 18, 2020 •

edited

Loading

oleq left a comment

oleq left a comment

oleq left a comment

oleq Feb 20, 2020

jodator Feb 20, 2020

jodator Feb 20, 2020

oleq Feb 21, 2020

jodator Feb 21, 2020

jodator Feb 21, 2020

oleq commented Feb 20, 2020

I/6113: Base table selection plugin #230

I/6113: Base table selection plugin #230

Conversation

jodator commented Jan 29, 2020 • edited Loading

Suggested merge commit message (convention)

Additional information

jodator commented Feb 18, 2020 • edited Loading

oleq left a comment

Choose a reason for hiding this comment

oleq left a comment

Choose a reason for hiding this comment

oleq left a comment

Choose a reason for hiding this comment

oleq Feb 20, 2020

Choose a reason for hiding this comment

jodator Feb 20, 2020

Choose a reason for hiding this comment

jodator Feb 20, 2020

Choose a reason for hiding this comment

oleq Feb 21, 2020

Choose a reason for hiding this comment

jodator Feb 21, 2020

Choose a reason for hiding this comment

jodator Feb 21, 2020

Choose a reason for hiding this comment

oleq commented Feb 20, 2020

jodator commented Jan 29, 2020 •

edited

Loading

jodator commented Feb 18, 2020 •

edited

Loading