Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review behavior of existing features on multi-range selections in tables #6116

Closed
jodator opened this issue Jan 22, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1830
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@jodator
Copy link
Contributor

jodator commented Jan 22, 2020

📝 Provide a description of the improvement

Most of the CKEditor 5 features are already implemented with multi-range selection in mind or they operate on multiple nodes by default. However, as we introduce a multi-range selection as a supported solution in the model, we must check how features integrate with such a selection.

Add integration tests for the existing features that will validate that existing CKEditor 5 features works with a selected table fragment (multi-range selection).

Requires #6113.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Jan 22, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jan 27, 2020
@jodator jodator modified the milestones: nice-to-have, iteration 30 Jan 28, 2020
@Reinmar Reinmar changed the title Review behavior of existing features on multi a seleted table fragment Review behavior of existing features on multi-range selections in tables Feb 20, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 26, 2020

May be blocked by #6328.

@oleq
Copy link
Member

oleq commented Mar 4, 2020

Features broken so far when executed on a multi-cell selection (they crash):

  • horizontal line
  • page break
  • special characters,
  • pasting

I checked some of them and it mostly comes down to the InputCommand working on the first range only and passing a selection based on that range to Model#deleteContent which does not allow the TableSelection hook to kick in.

If we fixed that, then the Model#insertContent would also probably fail, but this is another issue.

@oleq oleq removed their assignment Mar 5, 2020
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Mar 9, 2020
Other: Introduced support for multi-range selections. Closes ckeditor/ckeditor5#6116.
Reinmar added a commit to ckeditor/ckeditor5-typing that referenced this issue Mar 9, 2020
Other: Introduced support for multi-range selections. See ckeditor/ckeditor5#6116.
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 9, 2020
Internal: We need to take care of putting the selection in a correct position. See ckeditor/ckeditor5#6116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants