This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Introduced support for multi-range selections. Closes ckeditor/ckeditor5#6116. Closes ckeditor/ckeditor5#2010.
Additional information
Accompanied with:
By far the most tricky part of this task. I had to find the right balance between the
deleteContent()
(and henceinsertContent()
) doing reasonable things and overcomplicating them on the cost of maintenance issues and affecting some other cases (mostly: track changes).By the occam's razor's call I chose the simplest solution – removing code. I removed some quite unnecessary behaviour from
deleteContent()
and hence was able to use the selection's real position ininsertContent()
.During the course of action I also stumbled upon a case where the schema's method was leaking out of the limit element and putting selection on a table cell instead. It was visible when pasting a word over multi-cell selection in an empty table. I fixed this too.