-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricted editing #5683
Comments
IconTwo proposals here, I prefer the first one, but it might be confusing for the user because eg. restricted editable won't work for blocks of paragraphs. Dropdown proposalDuring the research of restricted editing in the Microsoft Word, I have found a decent improvement of this feature: moving between editables. Maybe it's worth to consider it after MVP implementation. Highlight colorWord is using light yellow color for their restricted editables and it could work for us too, but we have comments feature with a comparable color. So I would propose something similar - orangish. In comparison, I'm adding here a "blue mockup" also. OrangishBluishHighlight styleIt was a kinda tricky thing because I have been there during research on track-changes / comments & user selection features. To sum up, I'm recommending to mark editable areas similar to the highlight plugin way, but also Microsoft Word solution ( Bordered highlight (looks buggy)Brackets highlight (Word solution)Brackets solution mockuped on live editor instance: |
To track the progress of the feature I've added a detailed list with things to do in this task - not that the list may change. |
After implementing plugins for the "standard" mode - in which content creators will mark parts of the content as "exceptions" in the "restricted" mode - I'm not sure if we should focus on "opening" parts of text rather then "locking". As for now, I think that the button shouldn't be named "Restricted Edting" and maybe it's UI should be focused on the "opening" (adding exceptions) to the parts of texts. In the draft PR I've renamed this part of the |
Notes from the call about the UI: Standard mode
Restricted mode
|
📝 Provide a description of the new feature
This enhancement would allow to run the editor in two editing modes:
The feature would allow to mark editor's content part as an editable part (see Marking as editable part).
Editing mode can changed at a
runtime, via an API call.by configuring the editor. The modes should be operated by different users so there is no need to switch it in the same editor.UC: Marking as editable part
Marking any part as editable should be possible only while in standard mode and it should be doable using a button. Below is an example UC:
✔️ Expected result
UC: Editable part toggling
✔️ Expected result
📃 Other details
I intentionally didn't use full editing mode as it might bring up some historical connotations with our lovely full package 🙂
Restricted editing mode enhancements (part III - follow-up PRs)
Follow ups:
If you'd like to see this feature implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: