Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/5683: Initial implementation of the "standard" mode. #1

Merged
merged 41 commits into from
Nov 19, 2019
Merged

I/5683: Initial implementation of the "standard" mode. #1

merged 41 commits into from
Nov 19, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Nov 15, 2019 •
edited
Loading

Suggested merge commit message (convention)

Internal: Add initial "standard" mode implementation. Closes ckeditor/ckeditor5#5754.

Additional information

  • This is a draft PR to check CI setup later on.
  • As for names: I'd go with RestrictedEditingException for this part of a feature for now. This is how word calls this action (step 5).

jodator and others added 30 commits November 15, 2019 14:50
@jodator
Define text attribute marking non-restricted parts of content.
8e70ef1
@jodator
Define basic conversion for non restricted text attribute.
417cdaf
@jodator
Add command for marking parts of content as non restricted to editing.
6b2d6b1
@jodator
Add manual test for restricted document.
e53b07b
@jodator
Add restricted document command first tests.
9d8fbc7
@jodator
Add restricted document ui first tests.
2b2dd74
@jodator
Split restricted editing plugins.
6d04c19
@jodator
Use async/await in restricted document tests.
abf3ee8
@jodator
Do not check for the editor element in after each().
1d3bdf3
@jodator
Add icon for restricted document.
40e7e83
@jodator
Use preliminary icon design in manual test.
1477dfa
@jodator
Add test for selection with mixed parts of text.
56e4cea
@jodator
Add execute() test for partial attribute selected.
ccd1746
@jodator
Test only execute() outcome - not the value.
05fd7ba
@jodator
Remove .only from tests.
ceab8d5
@jodator
Unify tests.
25d2a4a
@jodator
Reword tests.
a7b237a
@jodator
Wrap RestrictedDocumentCommand.execute() test for non-collapsed selec…
b43bd75 
…tion.
@jodator
Handle collapsed selection in text without attribute.
d1a2771
@jodator
Handle collapsed selection in text with attribute.
c1ec0a6
@jodator
Remove leftover HTML markup from restricted document manual tests.
a5efd7c
@jodator
Add table to restricted document manual test.
30d9d86
@jodator
Add description to the restricted document manual test.
67840e8
@jodator
Merge branch 'master' into i/5683
bcd4c7f
@jodator
Fix paths to ckeditor5-core modules.
1f7d560
@jodator
Add sample.jpg for tests.
37d4b42
@jodator
Add dependencies to package.json.
7a60e98
@jodator
Add tests for forceValue option.
5b8d4f1
@jodator
Fix modules definitions.
da2ead8
@jodator
Rename nonRestricted attribute to restrictedEditingException.
a7da7ad
@jodator jodator marked this pull request as ready for review November 15, 2019 15:59
@jodator jodator requested review from oleq and Reinmar November 15, 2019 16:37
@Reinmar Reinmar removed their request for review November 18, 2019 07:41
oleq
oleq suggested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor language corrections only.

package.json Outdated Show resolved Hide resolved
src/restrictededitingexceptionui.js Outdated Show resolved Hide resolved
tests/manual/restrictedediting.md Outdated Show resolved Hide resolved
tests/restrictededitingexceptioncommand.js Outdated Show resolved Hide resolved
tests/restrictededitingexceptioncommand.js Outdated Show resolved Hide resolved
tests/restrictededitingexceptionediting.js Outdated Show resolved Hide resolved
tests/restrictededitingexceptionediting.js Outdated Show resolved Hide resolved
tests/restrictededitingexceptionui.js Outdated Show resolved Hide resolved
tests/restrictededitingexceptionui.js Outdated Show resolved Hide resolved
tests/restrictededitingexceptionui.js Outdated Show resolved Hide resolved
oleq
oleq suggested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor language corrections only.

@jodator jodator requested a review from oleq November 19, 2019 11:03
@oleq oleq merged commit e32a805 into master Nov 19, 2019
@oleq oleq deleted the i/5683 branch November 19, 2019 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oleq oleq Awaiting requested review from oleq

Assignees

@oleq oleq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restricted Editing: Standard mode
2 participants
@jodator @oleq