Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Migrate React integration to use generated typings #13542

Closed
arkflpc opened this issue Feb 24, 2023 · 1 comment · Fixed by ckeditor/ckeditor5-react#367
Closed

[TS] Migrate React integration to use generated typings #13542

arkflpc opened this issue Feb 24, 2023 · 1 comment · Fixed by ckeditor/ckeditor5-react#367
Assignees
@niegowski
Labels
domain:ts squad:core Issue to be handled by the Core team.
Milestone
iteration 61 (v37...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Feb 24, 2023 •
edited
Loading

Part of #13471.
@arkflpc arkflpc added the squad:core Issue to be handled by the Core team. label Feb 24, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Feb 24, 2023
@Witoso
Copy link
Member

Witoso commented Mar 13, 2023

The result of PoC:

  • React project using angular integration (updated in [TS] PoC of using types in React integration #13546) and alpha.1 release. On ckeditor5 repo in the dedicated branch.
  • Write down how the integration went. What steps happened, etc. what was not obvious, did it help, in what, we could later reuse it in guides for this dedicated technology and in TS blog post.

@ckeditor ckeditor deleted a comment from Witoso Mar 15, 2023
@niegowski niegowski self-assigned this Mar 15, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 15, 2023
@niegowski niegowski removed their assignment Mar 15, 2023
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Mar 15, 2023
@niegowski niegowski self-assigned this Mar 20, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 20, 2023
@niegowski niegowski mentioned this issue Mar 23, 2023
Merged
@filipsobol filipsobol mentioned this issue Mar 27, 2023
Merged
pomek added a commit to ckeditor/ckeditor5-linters-config that referenced this issue Mar 29, 2023
@pomek
Merge pull request #12 from ckeditor/ck/13542-add-support-for-linting…
02be5fa 
…-tsx-files

Feature: Add support for linting `.tsx` files. Related to ckeditor/ckeditor5#13542.
pomek added a commit to ckeditor/ckeditor5-react that referenced this issue Mar 29, 2023
@pomek
Merge pull request #367 from ckeditor/ck/13542
4f6c383 
Feature: Migrate package to TypeScript. Closes ckeditor/ckeditor5#13542.

MAJOR BREAKING CHANGE: Integration now requires Editor version 37 or later.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 29, 2023
@CKEditorBot CKEditorBot added this to the iteration 61 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:ts squad:core Issue to be handled by the Core team.
Projects
None yet
Milestone
iteration 61 (v37.0.0)
Development

Successfully merging a pull request may close this issue.

Migration to TS ckeditor/ckeditor5-react
5 participants
@Reinmar @niegowski @arkflpc @Witoso @CKEditorBot