Migration to TS #367
Merged
Migration to TS #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martnpaneq
reviewed
Mar 24, 2023
martnpaneq
reviewed
Mar 28, 2023
…ix." This reverts commit ea77c72.
…alization, in case the handler after initialization
martnpaneq
approved these changes
Mar 28, 2023
pomek
reviewed
Mar 28, 2023
There was a problem hiding this comment.
As I am not in the process, I do not understand why we have two samples:
sample/demo-*/
I can guess that the first is just a sample using the component and some CKEditor 5 build, while the second is a demo application (more realistic scenario). It would be good to describe both in README and explain which should be checked before releasing a new version. Maybe we do not need the sample/ directory anymore. Instead, we should develop example applications that could be checked using E2E tests on CI.
|
WDYT about dropping support for non-supported React versions? It means the CKEditor component will require React 18.0+.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Migrate package to TypeScript. Closes ckeditor/ckeditor5#13542.
MAJOR BREAKING CHANGE: Integration now requires Editor version 37 or later.