Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a fixer for the "ckeditor5-rules/license-header" rule #11473

Closed
pomek opened this issue Mar 16, 2022 · 0 comments · Fixed by ckeditor/ckeditor5-linters-config#17
Closed

Create a fixer for the "ckeditor5-rules/license-header" rule #11473

pomek opened this issue Mar 16, 2022 · 0 comments · Fixed by ckeditor/ckeditor5-linters-config#17
Assignees
@przemyslaw-zan
Labels
domain:linters This issue touches the "ckeditor/ckeditor5-linters-config" repository. squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 64 (v38...

Comments

@pomek
Copy link
Member

pomek commented Mar 16, 2022

📝 Provide a description of the improvement

Recently, we created the ckeditor5-rules/license-header for both linters:

The stylelint rule can fix issues that it detects. To simplify the scope, we agreed to implement a fixer for eslint later.

Scope

  • When the ckeditor5-rules/license-header found an issue with license headers in *.js files, it could try to fix it.
  • For inspiration, see how the rule for stylelint handles it.
  • Do not forget about covering the change with tests.
@pomek pomek added type:improvement This issue reports a possible enhancement of an existing feature. squad:platform Issue to be handled by the Platform team. domain:linters This issue touches the "ckeditor/ckeditor5-linters-config" repository. labels Mar 16, 2022
@przemyslaw-zan przemyslaw-zan self-assigned this May 11, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 11, 2023
@przemyslaw-zan przemyslaw-zan mentioned this issue May 12, 2023
Merged
pomek added a commit to ckeditor/ckeditor5-linters-config that referenced this issue May 17, 2023
@pomek
Merge pull request #17 from ckeditor/ck/11473
2873ecc 
Feature (eslint-plugin-ckeditor5-rules): Added fixer for the `license-header` rule. Closes ckeditor/ckeditor5#11473.

Tests (eslint-plugin-ckeditor5-rules): Added support for using fixtures in tests. Currently only implemented in the `license-header` rule tests. Closes ckeditor/ckeditor5#11473.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 17, 2023
@CKEditorBot CKEditorBot added this to the iteration 64 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
domain:linters This issue touches the "ckeditor/ckeditor5-linters-config" repository. squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 64 (v38.1.0)
Development

Successfully merging a pull request may close this issue.

New fixer and fixtures in tests ckeditor/ckeditor5-linters-config
3 participants
@pomek @CKEditorBot @przemyslaw-zan