New fixer and fixtures in tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martnpaneq
reviewed
May 15, 2023
packages/eslint-plugin-ckeditor5-rules/lib/rules/license-header.js
Outdated
Show resolved
Hide resolved
...s/eslint-plugin-ckeditor5-rules/tests/fixtures/license-header/valid/header_and_whitespace.js
Outdated
Show resolved
Hide resolved
martnpaneq
approved these changes
May 16, 2023
|
I've removed the broken test. The case it is testing works when when actually using fixer with the new rule, both with our regular eslint config, as well as when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature (eslint-plugin-ckeditor5-rules): Added fixer for the
license-headerrule. Closes ckeditor/ckeditor5#11473.Tests (eslint-plugin-ckeditor5-rules): Added support for using fixtures in tests. Currently only implemented in the
license-headerrule tests. Closes ckeditor/ckeditor5#11473.