This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Do not register batches which have only non-document operations #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Feb 22, 2018
| @@ -65,6 +65,13 @@ export default class UndoEngine extends Plugin { | |||
|
|
|||
| this.listenTo( this.editor.model, 'applyOperation', ( evt, args ) => { | |||
| const operation = args[ 0 ]; | |||
|
|
|||
| // Do not register batch if the operation is not a document operation. | |||
| // This prevents from creating empty undo steps, where all operations where non-document operations. | |||
There was a problem hiding this comment.
Unless you consider this completely obvious that undo should not record these changes?
There was a problem hiding this comment.
Well, I consider everything obvious :). I'll add one more line of comment to make it more obvious.
|
But I confirm that the fix work. |
|
I've completed requested changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Do not register batches which have only non-document operations. Closes ckeditor/ckeditor5#2719. Closes ckeditor/ckeditor5#781.