Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not register batches which have only non-document operations #2719

Closed
scofalik opened this issue Feb 21, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-undo#80
Closed

Do not register batches which have only non-document operations #2719

scofalik opened this issue Feb 21, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-undo#80
Assignees
@scofalik
Labels
package:undo type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@scofalik
Copy link
Contributor

Originally reported in: #781

It appears that batches that operates solely on document fragments are still registered in undo, creating empty undo steps and throwing editor. Such batches should be filtered.
@scofalik scofalik self-assigned this Feb 21, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-undo Feb 22, 2018
@Reinmar
Merge pull request #80 from ckeditor/t/79
60ac1ab 
Fix: Do not register batches which have only non-document operations. Closes #79. Closes ckeditor/ckeditor5#781.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-undo Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:undo labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:undo type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Do not register batches which have only non-document operations ckeditor/ckeditor5-undo
2 participants
@scofalik @mlewand