This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fixing selection after mutation is handled #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Multiple characters are changed at once instead of one-by-one.
|
I found one small issue https://github.com/ckeditor/ckeditor5-typing/issues/54, but it's a non blocker. The rest works perfectly. Another thing is that the whole algorithm inside mutation handler is long and complicated and it doesn't have unit tests. I reported it in https://github.com/ckeditor/ckeditor5-typing/issues/55. |
Reinmar
approved these changes
Oct 17, 2016
This was referenced Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ckeditor/ckeditor5#3060
Related PR in engine: ckeditor/ckeditor5-engine#626