This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
ViewSelection instance is passed with viewMutations in mutations events, if possible. #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please correct the CC and and I'm merging this. |
|
One more thing is missing – definition of the new param here: https://github.com/ckeditor/ckeditor5-engine/pull/626/files#diff-57e194ad013563b5752afa147f447d67R237 |
… is in a new node.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements some ideas and fixes some issues described in ckeditor/ckeditor5#3699.
This PR introduces
viewSelectionparameter tomutationsevent.viewSelectionis instance ofengine.view.Selectioncreated basing on actual DOM selection.viewSelectionis set only if DOM selection got correctly mapped to view. This means that it is available only when after mutations selection is placed in an already existing DOM node.For now I feel this is enough. It solves an issue in
Typingand right now we don't know whether anything else will use mutations.Additionally, if DOM selection ends up in non-existing DOM node, we need to add a node in model anyway. This means that we should be able to handle setting model selection at that point.