Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86: Addressed the react-fast-compare circular refs warning #91

Closed
wants to merge 5 commits into from

Conversation

oleq
Copy link
Member

@oleq oleq commented Jul 23, 2020

Fix: Addressed the react-fast-compare circular refs warning by avoiding references to editor nodes in the redux data store. Closes #86.

@oleq
Copy link
Member Author

oleq commented Jul 23, 2020

self#R-: there are some issues with the node inspector.

@oleq
Copy link
Member Author

oleq commented Jul 28, 2020

This approach turned out to be a dead end. The new solution is in #93.

@oleq oleq closed this Jul 28, 2020
@oleq oleq deleted the i/86-react-fast-compare branch July 28, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-fast-compare cannot handle circular refs warning in the console
1 participant