Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-fast-compare cannot handle circular refs warning in the console #86

Closed
oleq opened this issue Jun 2, 2020 · 2 comments · Fixed by #93
Closed

react-fast-compare cannot handle circular refs warning in the console #86

oleq opened this issue Jun 2, 2020 · 2 comments · Fixed by #93
Assignees
@oleq
Labels
squad:dx type:bug
Milestone
iteration 35

Comments

@oleq
Copy link
Member

oleq commented Jun 2, 2020

@oleq oleq added the type:bug label Jun 2, 2020
@Reinmar
Copy link
Member

Reinmar commented Jun 23, 2020

I get this warning too. It's pretty annoying. Since @oleq is on 🌴 , does anyone else want to give it a try?

@oleq oleq self-assigned this Jul 23, 2020
@oleq oleq added this to the iteration 34 milestone Jul 23, 2020
@oleq oleq mentioned this issue Jul 23, 2020
Closed
@Reinmar Reinmar modified the milestones: iteration 34, iteration 35 Jul 27, 2020
@FilipTokarski
Copy link
Member

This thing seems to be causing a very long lag/freeze if you do some operations on tables in Safari ( it's not as noticeable in Chrome and FF ). Sometimes I have to wait like 10 seconds before inserting a new column and I get up to hundreds of this warnings at once:

27_safari2

@oleq oleq added the squad:dx label Jul 28, 2020
@jodator jodator removed the squad:red label Jul 28, 2020
@oleq oleq mentioned this issue Jul 28, 2020
Merged
jodator added a commit that referenced this issue Jul 30, 2020
@jodator
Merge pull request #93 from ckeditor/i/86-react-fast-compare-2
a5b4e67 
Fix: Addressed the "react-fast-compare circular refs" warning by switching to lodash `isEqual()`. Closes #86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
squad:dx type:bug
Projects
None yet
Milestone
iteration 35
4 participants
@Reinmar @jodator @oleq @FilipTokarski