Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the "data-cke-inspector" attribute to the CSS selectors #107

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Added the "data-cke-inspector" attribute to the CSS selectors #107

merged 4 commits into from
Dec 4, 2020

Conversation

pomek
Copy link
Member

@pomek pomek commented Dec 3, 2020

Other: Added the [data-cke-inspector=true] attribute to the CSS selectors. Closes #106.

image

oleq
oleq reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@oleq oleq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use singletonStyleTag in prod to simplify it even further?

@pomek
Copy link
Member Author

pomek commented Dec 3, 2020

Dev:

image

Prod:

image

@oleq
Copy link
Member

oleq commented Dec 4, 2020

FYI: I used the .ck-inspector namespace for custom properties in the project as suggested in ckeditor/ckeditor5#7953.

@oleq oleq merged commit ee9cb3f into master Dec 4, 2020
@oleq oleq deleted the i/106 branch December 4, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleq oleq oleq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach the [data-ckeditor-inspector=true] attribute to output CSS selectors
2 participants
@pomek @oleq