Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach the [data-ckeditor-inspector=true] attribute to output CSS selectors #106

Closed
pomek opened this issue Dec 3, 2020 · 0 comments · Fixed by #107
Closed

Attach the [data-ckeditor-inspector=true] attribute to output CSS selectors #106

pomek opened this issue Dec 3, 2020 · 0 comments · Fixed by #107
Assignees
@pomek
Labels
squad:dx type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 38

Comments

@pomek
Copy link
Member

pomek commented Dec 3, 2020

A similar to what we do in CKE 5:

image

When reading the code, it allows skipping selectors that were added by the inspector.
@pomek pomek added the type:task This issue reports a chore (non-production change) and other types of "todos". label Dec 3, 2020
@pomek pomek self-assigned this Dec 3, 2020
@pomek pomek added this to the iteration 38 milestone Dec 3, 2020
@pomek pomek mentioned this issue Dec 3, 2020
Merged
@oleq oleq closed this as completed in #107 Dec 4, 2020
oleq added a commit that referenced this issue Dec 4, 2020
@oleq
Merge pull request #107 from ckeditor/i/106
ee9cb3f 
Other: Added the `data-cke-inspector=true` attribute to all `<style>` tags injected by the application. Closes #106.

Also:
* Reduced the number of `<style>` tags injected by the application.
* Used the `.ck-inspector` namespace for CSS custom properties used by the inspector to clean up the developer tools and improve DX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
squad:dx type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 38
Development

Successfully merging a pull request may close this issue.

Added the "data-cke-inspector" attribute to the CSS selectors ckeditor/ckeditor5-inspector
2 participants
@Reinmar @pomek