Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render the inspector panes/trees when the inspector is collapsed #80

Closed
oleq opened this issue May 25, 2020 · 1 comment · Fixed by #96
Closed

Don't render the inspector panes/trees when the inspector is collapsed #80

oleq opened this issue May 25, 2020 · 1 comment · Fixed by #96

Comments

@oleq
Copy link
Member

oleq commented May 25, 2020

ATM even when the inspector is collapsed, it renders all the UI (and first collects data from the editor to do that) which degrades performance when working with large documents.

Fixing this should be fairly simple (around

onModelChange() {
CKEditorInspector._store.dispatch( updateModelState() );
CKEditorInspector._store.dispatch( updateCommandsState() );
},
onViewRender() {
CKEditorInspector._store.dispatch( updateViewState() );
}
+ few store dispatches when the inspector is uncollapsed to stay in sync) and that would help using editor manual test with large content by simply collapsing the inspector.

A follow-up of #79. Related to #71.

@oskarwrobel
Copy link

This improvement will be very important for documents with markers. Now when there are several markers in the document then performance drop is very noticeable.

@oleq oleq self-assigned this Jul 30, 2020
@oleq oleq added this to the iteration 35 milestone Jul 30, 2020
@pomek pomek closed this as completed in #96 Jul 31, 2020
pomek added a commit that referenced this issue Jul 31, 2020
Other: Do not update the inspector on editor events when the UI is collapsed. Closes #80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants