Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease the number of unnecessary React component renders #79

Closed
oleq opened this issue May 25, 2020 · 0 comments · Fixed by #81
Closed

Decrease the number of unnecessary React component renders #79

oleq opened this issue May 25, 2020 · 0 comments · Fixed by #81
Assignees
@oleq
Labels
squad:red type:improvement
Milestone
iteration 33

Comments

@oleq
Copy link
Member

oleq commented May 25, 2020 •
edited
Loading

I noticed that the initial implementation wasn't very quick. For instance, typing some text caused rendering in all react inspector components:

After some quite easy refactoring (with the help of React dev tools) I managed to update only these components that should be updated:

It visibly speeds up the inspector when working with large documents.
@oleq oleq added this to the iteration 33 milestone May 25, 2020
@oleq oleq self-assigned this May 25, 2020
This was referenced May 25, 2020
Closed
Merged
jodator added a commit that referenced this issue May 27, 2020
@jodator
Merge pull request #81 from ckeditor/i/79
44e7850 
Fix: Improved performance of the inspector by avoiding unnecessary React rendering. Closes #79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
squad:red type:improvement
Projects
None yet
Milestone
iteration 33
2 participants
@Reinmar @oleq