Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bookmarks created inside temporary elements #3487

Merged
merged 9 commits into from
Sep 25, 2019
+148 −27
Merged

Fix for bookmarks created inside temporary elements #3487

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
01b1eaf
Add unit tests.
Comandeer Sep 23, 2019
6a9be50
Update manual test.
Comandeer Sep 24, 2019
4b25e68
Force bookmarks to be created outside temporary elements.
Comandeer Sep 24, 2019
6c2ce18
Always select bookmarks after copying widget.
Comandeer Sep 24, 2019
c9bf082
Update issues numbers in manual test.
Comandeer Sep 24, 2019
9c1bab2
Add unit test for widgets.
Comandeer Sep 24, 2019
6dfd139
Add unit tests for copybin and pastebin.
Comandeer Sep 25, 2019
0274b34
Omit copybin and pastebin.
Comandeer Sep 25, 2019
1115bb3
Changelog entry. [skip ci]
f1ames Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Omit copybin and pastebin.
@Comandeer
Comandeer committed Sep 25, 2019
commit 0274b34329fc876bddd334c7b8deca9e46a1bec3
11 changes: 10 additions & 1 deletion core/dom/range.js
View file
Original file line number Diff line number Diff line change
@@ -801,9 +801,18 @@ CKEDITOR.dom.range = function( root ) {

function getTemporary( node ) {
return node.getAscendant( function( node ) {
return node.data && node.data( 'cke-temp' );
return node.data && node.data( 'cke-temp' ) && !isClipboardBin( node );
}, true );
}

function isClipboardBin( node ) {
var ids = [
'cke_copybin',
'cke_pastebin'
];

return CKEDITOR.tools.array.indexOf( ids, node.getAttribute( 'id' ) ) !== -1;
}
},

/**