Fix for bookmarks created inside temporary elements #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the CI was red, I have extracted the refactor commit to |
|
Seems like this breaks clipboard operations for widgets in IE8 - cutting, copying and pasting (dragging works fine). |
|
I've slightly modified |
2 tasks
f1ames
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
LGTM 👍
Unit tests
- Chrome (CI) ✅
- Firefox (CI) ✅
- Safari (dev & build) ✅✅
- IE8 (build) ✅
- IE11 (dev & build) ✅✅
- Edge (dev & build) ✅✅
Manual tests
With help of @msamsel and @Dumluregn 👍
- Chrome ✅
- Firefox ✅
- Safari ✅
- IE8 🚨 (issue with copy/paste, see - Fix for bookmarks created inside temporary elements #3487 (comment))
- IE9 ✅
- IE10 ✅
- IE11 ✅
After copypin/pastebin fix:
Unit tests
- Chrome (CI) ✅
- Firefox (CI) ✅
is:unit,path:/tests/plugins/widget,path:/tests/plugins/uploadwidget,name:bookmarks,path:/tests/core/dom,path:/tests/core/selection
- Safari (dev) ✅
- IE8 (dev) ✅
- IE9 (dev) ✅
- IE10 (dev) ✅
- IE11 (dev) ✅
- Edge (dev) ✅
Manual tests
is:manual,name:clipboardhtml,name:clipboardhtmlselectall,name:embed
- Chrome ✅
- Firefox ✅
- Safari ✅
- IE8 ✅
- IE9 ✅
- IE10 ✅
- IE11 ✅
- Edge ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What is the proposed changelog entry for this pull request?
What changes did you make?
I've forced bookmarks to be created outside temporary elements (elements with
[data-cke-temp=1]). Thanks to that, widgets can now always restore bookmarks after copying.I've also refactored
CKEDITOR.dom.range#createBookmarks()by deduplicating logic connected with creating bookmark nodes. However this commit can be extracted to separate PR.Closes #3423.
Closes #3482.