Fix type error while opening context menu in readonly editor

CHANGES.md

@@ -3,6 +3,10 @@
 
 ## CKEditor 4.10.2
 
+Fixed Issues:
+
+* [#1181](https://github.com/ckeditor/ckeditor-dev/issues/1181): [Chrome] Fixed: Opening context menu in readonly editor results in error.
+
 ## CKEditor 4.10.1
 
 Fixed Issues:

plugins/contextmenu/plugin.js

@@ -111,7 +111,9 @@ CKEDITOR.plugins.add( 'contextmenu', {
 				 * @param {Number} [offsetY]
 				 */
 				open: function( offsetParent, corner, offsetX, offsetY ) {
-					if ( this.editor.config.enableContextMenu === false ) {
+					// Do not open context menu if it's disabled or there is no selection in the editor (#1181).
+					if ( this.editor.config.enableContextMenu === false ||
+						this.editor.getSelection().getType() === CKEDITOR.SELECTION_NONE ) {
 						return;
 					}
 

tests/_benderjs/ckeditor/static/bot.js

@@ -232,7 +232,8 @@
 		 */
 		contextmenu: function( callback ) {
 			var editor = this.editor,
-				tc = this.testCase;
+				tc = this.testCase,
+				range;
 
 			editor.once( 'panelShow', function() {
 				// Make sure resume comes after wait.
@@ -245,10 +246,20 @@
 				} );
 			} );
 
+			// Force selection in the editor as opening menu
+			// by user always results in selection in non readonly editor.
+			if ( !editor.readOnly && editor.getSelection().getType() === CKEDITOR.SELECTION_NONE ) {
+				range = editor.createRange();
+
+				range.selectNodeContents( editor.editable() );
+				range.collapse( true );
+				range.select();
+			}
+
 			// Open context menu on editable element.
 			editor.contextMenu.open( editor.editable() );
 
-			// combo panel opening is synchronous;
+			// Combo panel opening is asynchronous.
 			tc.wait();
 		},
 

tests/plugins/contextmenu/contextmenu.js

@@ -11,6 +11,7 @@
 			var ed1 = this.editor,
 				bot1 = this.editorBot;
 
+			ed1.focus();
 			bot1.contextmenu( function( menu1 ) {
 				// Check DOM focus and virtual editor focus.
 				assert.areSame( menu1._.panel._.iframe, CKEDITOR.document.getActive(), 'check DOM focus inside of panel' );
@@ -36,7 +37,7 @@
 				name: 'editor_nocontextmenu1'
 			}, function( bot ) {
 				bot.editor.contextMenu.show = sinon.spy();
-
+				bot.editor.focus();
 				bot.editor.contextMenu.open( bot.editor.editable() );
 
 				assert.isTrue( bot.editor.contextMenu.show.called );
@@ -51,7 +52,7 @@
 					}
 				}, function( bot ) {
 				bot.editor.contextMenu.show = sinon.spy();
-
+				bot.editor.focus();
 				bot.editor.contextMenu.open( bot.editor.editable() );
 
 				assert.isFalse( bot.editor.contextMenu.show.called );
@@ -121,6 +122,22 @@
 					assert.isFalse( !!editor.getSelection().isFake, 'Fake selection is not set for nested editables' );
 				} );
 			} );
+		},
+
+		// (#1181)
+		'test open context menu when no selection in the editor': function() {
+			bender.editorBot.create( {
+				name: 'editor_noselection'
+			}, function( bot ) {
+				var editor = bot.editor;
+
+				editor.contextMenu.show = sinon.spy();
+
+				editor.getSelection().removeAllRanges();
+				editor.contextMenu.open( editor.editable() );
+
+				assert.isFalse( editor.contextMenu.show.called );
+			} );
 		}
 	} );
 } )();

tests/plugins/contextmenu/integration.js

@@ -28,6 +28,7 @@
 					} );
 				} );
 
+				editor.focus();
 				editor.contextMenu.open( editor.editable() );
 
 				wait();
@@ -55,6 +56,7 @@
 					} );
 				} );
 
+				editor.focus();
 				editor.contextMenu.open( editor.editable() );
 
 				wait();
@@ -87,6 +89,7 @@
 					editor.contextMenu.open( editor.editable() );
 				} );
 
+				editor.focus();
 				editor.contextMenu.open( editor.editable() );
 
 				wait();
@@ -103,6 +106,7 @@
 					} );
 				} );
 
+				bot.editor.focus();
 				bot.editor.contextMenu.open( bot.editor.editable() );
 
 				wait();

tests/plugins/contextmenu/manual/readonly.html

@@ -0,0 +1,13 @@
+<div id="editor">
+	<p>I am a sample content with <a href="https://ckeditor.com">link</a>.</p>
+</div>
+
+<script>
+	if ( CKEDITOR.env.mobile || !CKEDITOR.env.chrome ) {
+		bender.ignore();
+	}
+
+	CKEDITOR.replace( 'editor', {
+		readOnly: true
+	} );
+</script>

tests/plugins/contextmenu/manual/readonly.md

@@ -0,0 +1,20 @@
+@bender-ui: collapsed
+@bender-tags: bug, 4.10.2, 1181
+@bender-ckeditor-plugins: wysiwygarea, toolbar, contextmenu, link, clipboard
+
+1. Open console.
+2. Right click on the link without prior focusing the editor.
+
+## Expected
+
+Context menu does not appear.
+
+In case of Chrome on macOS: right-clicking on link will select it and open the context menu.
+
+## Unexpected
+
+There is an error inside the console:
+
+```
+Uncaught TypeError: Cannot read property 'checkReadOnly' of undefined
+```