Fix type error while opening context menu in readonly editor #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
added
the
review:easy
jacekbogdanski
requested changes
Aug 31, 2018
CHANGES.md
Outdated
| @@ -21,6 +21,7 @@ Fixed Issues: | |||
| * [#1916](https://github.com/ckeditor/ckeditor-dev/issues/1916): [IE9-11] Fixed: Pressing <kbd>Delete</kbd> key in [read-only mode](https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_editor.html#property-readOnly) throws an error. | |||
| * [#2254](https://github.com/ckeditor/ckeditor-dev/issues/2254): Fixed: [Image](https://ckeditor.com/cke4/addon/image) ratio locking is too precise for resized images. Thanks to [Jonathan Gilbert](https://github.com/logiclrd)! | |||
| * [#2003](https://github.com/ckeditor/ckeditor-dev/issues/2003): Fixed: Right-clicking on multiple selected cells containing empty paragraphs removes the selection on Firefox. | |||
| * [#1181](https://github.com/ckeditor/ckeditor-dev/issues/1181): [Chrome] Fixed: Opening context menu in readonly editor results in error. | |||
There was a problem hiding this comment.
Update changelog entry into 4.10.2.
| @@ -245,6 +246,16 @@ | |||
| } ); | |||
| } ); | |||
|
|
|||
| // Force selection in the editor as opening menu | |||
| // by user always results in selection. | |||
There was a problem hiding this comment.
It's not totally true, otherwise, we won't have this issue.
| @@ -0,0 +1,22 @@ | |||
| @bender-ui: collapsed | |||
| @bender-tags: bug, 4.10.1, 1181 | |||
There was a problem hiding this comment.
Update version tag into 4.10.2.
| @bender-tags: bug, 4.10.1, 1181 | ||
| @bender-ckeditor-plugins: wysiwygarea, toolbar, contextmenu, link, clipboard | ||
|
|
||
| **Test Scenario** |
There was a problem hiding this comment.
Please, keep our adopted manual test style:
1. ...
2. ...
3. ...
## Expected
...
## Unexpected
...
|
Rebased onto latest |
mlewand
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
I've added a simple check to open context menu only if there is selection inside the editor. In Chrome there is no selection inside the editor before the first focus. Unfortunately it required to update tests connected to context menu as many of them were fired on editor without the selection.
Closes #1181.