Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added email support for autolink plugin #1825

Merged
merged 5 commits into from
Mar 25, 2018
Merged

Added email support for autolink plugin #1825

merged 5 commits into from
Mar 25, 2018

Conversation

jacekbogdanski
Copy link
Member

What is the purpose of this pull request?

Feature request

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Added email support for autolink plugin.

Closes #1761

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix overally looks good, but some tests are failing in IE8:

  • test created protected mail link (function)
  • test created protected mail link (string)

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 036464c into major Mar 25, 2018
@Comandeer Comandeer deleted the t/1761 branch March 25, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants