Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and link email addresses in autolink plugin #1761

Closed
georgringer opened this issue Mar 7, 2018 · 3 comments
Closed

Detect and link email addresses in autolink plugin #1761

georgringer opened this issue Mar 7, 2018 · 3 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:autolink The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone

Comments

@georgringer
Copy link

georgringer commented Mar 7, 2018

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

  1. Enable the autolink plugin
  2. Write Paste an email address

Expected result

The email address should be linked with a mailto link

Actual result

The email address as text only.

@engineering-this engineering-this added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Mar 16, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. labels Mar 19, 2018
@jacekbogdanski jacekbogdanski added the plugin:autolink The plugin which probably causes the issue. label Mar 19, 2018
@jacekbogdanski
Copy link
Member

jacekbogdanski commented Mar 19, 2018

Hello,

I think you misunderstood how autolink plugin works. Currently it only turns the pasted URL text into a link. We decided to approve this feature request and it will be implemented consistent with autolink plugin behavior i.e. it will replace email addresses with correct link only when an email has been pasted.

Nevertheless you gave us a great feature idea to handle typed text with autolink plugin. I opened additional feature request for it: #1815.

If you like the idea please give it thumbs up so we will know that our community is interested in this feature.

@georgringer
Copy link
Author

Thanks for your response and explanation! I didn't know that it was only about pasting and certainly it is also very important to have those automated created links for typed urls as well.

We in the TYPO3 community are using ckeditor and those features are missing as it was possible in the previous editor.

@josefglatz
Copy link

actually TYPO3 has integrated a custom autolinking plugin without mailto-link support TYPO3/typo3@e096754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:autolink The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

6 participants