Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct error message for computeScriptHash #689

Merged
merged 2 commits into from
May 17, 2024

Conversation

twhy
Copy link
Contributor

@twhy twhy commented May 17, 2024

Description

This PR aims to fix error message "Expect type undefined ..." when calling computeScriptHash with invalid hex string.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview May 17, 2024 3:08am

.eslintrc.next.js Outdated Show resolved Hide resolved
@homura homura merged commit d483b92 into ckb-js:develop May 17, 2024
4 checks passed
@twhy twhy deleted the fix-error-message-for-computeScriptHash branch May 17, 2024 03:17
@github-actions github-actions bot mentioned this pull request May 17, 2024
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants