fix: correct error message for computeScriptHash (#689)

.changeset/silent-mangos-bow.md

@@ -0,0 +1,6 @@
+---
+"@ckb-lumos/codec": patch
+"@ckb-lumos/base": patch
+---
+
+fix: correct error message for computeScriptHash

packages/base/tests/utils.test.js

@@ -52,6 +52,14 @@ const scriptHash =
 
 test("computeScriptHash", (t) => {
   t.is(computeScriptHash(script), scriptHash);
+  t.throws(
+    () =>
+      computeScriptHash({ codeHash: "000", hashType: "type", args: "0x12" }),
+    {
+      instanceOf: Error,
+      message: new RegExp("Error at input.codeHash.*", "m"),
+    }
+  );
 });
 
 test("hashCode, should return same hash if same input", (t) => {

packages/codec/src/error.ts

@@ -46,10 +46,12 @@ export class CodecExecuteError extends Error {
     };
 
     const path = this.keys.reduceRight(reducer, "input");
+    const text =
+      this.origin instanceof CodecBaseParseError
+        ? `Expect type ${this.origin.expectedType} at ${path} but got error:`
+        : `Error at ${path}:`; // this.origin can be an Error at runtime
 
-    return `Expect type ${this.origin.expectedType} at ${path} but got error: ${
-      this.origin.message
-    }
+    return `${text} ${this.origin.message}
     ${this.origin.stack?.replace(/Error:.+?\n/, "")}
     `;
   }

packages/codec/src/utils.ts

@@ -13,7 +13,7 @@ const CHAR_f = "f".charCodeAt(0); // 102
 
 function assertStartsWith0x(str: string): void {
   if (!str || !str.startsWith("0x")) {
-    throw new Error("Invalid hex string");
+    throw new Error("Invalid hex string, expect starts with 0x");
   }
 }
 
@@ -79,6 +79,7 @@ export function assertHexString(str: string, byteLength?: number): void {
 export function assertUtf8String(str: string): void {
   for (let i = 0; i < str.length; i++) {
     const c = str.charCodeAt(i);
+    /* eslint-disable @typescript-eslint/no-magic-numbers */
     if (c > 0xff) {
       throw new Error("Invalid UTF-8 raw string!");
     }