Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Composer 2 #1

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Support Composer 2 #1

merged 6 commits into from
Nov 2, 2020

Conversation

mglaman
Copy link

@mglaman mglaman commented Oct 25, 2020

  Problem 1
    - civicrm/civicrm-core[5.29.0, ..., 5.31.x-dev] require civicrm/composer-downloads-plugin ^2.0 -> satisfiable by civicrm/composer-downloads-plugin[v2.0.0, v2.1.0, v2.1.1].
    - civicrm/composer-downloads-plugin[v2.0.0, ..., v2.1.1] require composer-plugin-api ^1.1 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - Root composer.json requires civicrm/civicrm-core ~5.29 -> satisfiable by civicrm/civicrm-core[5.29.0, ..., 5.31.x-dev].

@mglaman
Copy link
Author

mglaman commented Oct 25, 2020

This needs manual testing, I thought there was CI attached.

@seamuslee001
Copy link

@mglaman My unerstanding from @totten is that there needs to be some re-writing of this plugin because the underlying API within composer has changed from v1 => v2

@mglaman
Copy link
Author

mglaman commented Oct 29, 2020

Thanks, @seamuslee001, I assumed there would be something which broke. I'll see if I can work on the changes and support v1 and v2 of the API

@mglaman
Copy link
Author

mglaman commented Oct 29, 2020

Okay, I've added an Actions workflow and running the tests locally.

I'll work on fixing PharHandler where it's getting an incorrect directory for chmod

@mglaman
Copy link
Author

mglaman commented Oct 29, 2020

src/Handler/ArchiveHandler.php Outdated Show resolved Hide resolved
src/Handler/ArchiveHandler.php Outdated Show resolved Hide resolved
src/Handler/FileHandler.php Outdated Show resolved Hide resolved
tests/SniffTest.php Outdated Show resolved Hide resolved
@seamuslee001
Copy link

I've tested this on both a composer2 and composer1 install and have run unit tests with both and confirmed it works, I'm going to merge this and tag a new release

@mglaman
Copy link
Author

mglaman commented Nov 2, 2020

@seamuslee001 thanks! I'll try it out on my CI runs which install civicrm-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants