Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer 2 Support #5083

Closed
swissspidy opened this issue Oct 30, 2020 · 6 comments · Fixed by #5344
Closed

Composer 2 Support #5083

swissspidy opened this issue Oct 30, 2020 · 6 comments · Fixed by #5344
Labels
P3 Nice to have Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

Task Description

This is currently blocked as some dependencies need to be updated first.

civicrm/composer-downloads-plugin#1
ampproject/amp-wp#5551

@swissspidy swissspidy added Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling P3 Nice to have Pod: WP & Infra labels Oct 30, 2020
@seamuslee001
Copy link

Just FYI civicrm/composer-downloads-plugin now has a new version 3.0.0 which includes that PR mentioned

@seamuslee001
Copy link

just FYI i found a small php issue and fixed it so have pushed up 3.0.1 which should be used

@spacedmonkey
Copy link
Contributor

Current issues.

  Problem 1
    - cweagans/composer-patches is locked to version 1.6.7 and an update of this package was not requested.
    - cweagans/composer-patches 1.6.7 requires composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
  Problem 2
    - cweagans/composer-patches 1.6.7 requires composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - ampproject/amp-wp 2.0.5 requires cweagans/composer-patches 1.6.7 -> satisfiable by cweagans/composer-patches[1.6.7].
    - ampproject/amp-wp is locked to version 2.0.5 and an update of this package was not requested.

@swissspidy
Copy link
Collaborator Author

Once AMP plugin 2.0.6 is out this should all go away as we can then safely update all dependencies.

@pierlon
Copy link
Contributor

pierlon commented Nov 17, 2020

AMP plugin 2.0.6 is now out 🎉.

@swissspidy
Copy link
Collaborator Author

Moving back to backlog since AMP 2.0.7 reverted this due to compat issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Nice to have Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants