CRM-16421 - Installation - Update to newer protocol #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify the overall build/distribution process, this patch allows us to
include the `civicrm-setup` code with all builds. (Thus, it can be listed
as a dependency in `composer.json`.) The opt-in/opt-out mechanism is
a placeholder file in `${civicrm-core}/.use-civicrm-setup`.
|
Tested: Built via distmaker adding the two related patches created wp-empty and drupal empty via buildkit Installed on Joomla Test site, installed CiviCRM using *-joomla.zip. Used existing Installer, Install successful created wp-empty via buildkit @totten this looks good for merge |
|
Coo. I know it's a bit tricky to test this stuff (what with distmaker and multiple patches). So thank you, @kcristiano ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the recently-merged #121.
In #121, it was expected that some systems would opt-in to using the new installer, and others would opt-out. The mechanism for opt-in/opt-out was to download (or not download) the
civicrm-setupfolder.This patch revises the protocol -- you can download the
civicrm-setupfolder regardless of preference. To indicate the preferred installer, create (or delete) a file named.use-civicrm-setup. In terms of the overall build/distribution infrastructure, it's easier to support this protocol.