CRM-16421 - Add civicrm-setup. Build civicrm-*-wporg.zip #11576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421
---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421
|
jenkins, test this please |
|
Tested: Built via distmaker adding the two related patches created wp-empty and drupal empty via buildkit Installed on Joomla Test site, installed CiviCRM using *-joomla.zip. Used existing Installer, Install successful created wp-empty via buildkit @totten this looks good for merge |
|
Coo. I know it's a bit tricky to test this stuff (what with distmaker and multiple patches). So thank you, @kcristiano ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This patch adds a new library,
civicrm-setup, to the list of dependencies. The library is roughly akin tocivicrm/install/index.php, but it provides a defined API, more documentation, and more readable/digestable files. (Related: Draft blog: https://gist.github.com/totten/4b8d0b447f89763fe7781d3fc31d3656 )The library only operates on an opt-in basis: all the existing builds/installers should continue to work as before, unless they take some special action to use the new one.
Before
civicrm-setup.distmakergeneratescivicrm-X.Y.Z-wordpress.zip, which uses the existingcivicrm/install/index.php.After
civicrm-setup.distmakergeneratescivicrm-X.Y.Z-wordpress.zip, which uses the existingcivicrm/install/index.php. (Same as before.)distmakergeneratescivicrm-X.Y.Z-wporg.zip, which usescivicrm-setup. This ZIP file is identical, save for two changes:.use-civicrm-setupto activate the new installer.plugin/blocks/opt-in, which displays a set of "Opt-in" buttons on the install screen.civicrm-*-wporg.zipon WordPress, or...cv core:installto perform installation.Comments
This is a replacement for #11573 which aims to use a simpler distribution-channel.
Depends: civicrm/civicrm-wordpress#122
To test, I did this on a local machine:
distmakerto create tar/zip files.civihydrato build new test sites and to extract all the tar/zip files.*-wordpress.zip,*-wporg.zip,*-drupal.tar.gz,*-backdrop.tar.gz, and*-joomla.zip),As expected, the
*-wporg.zipdisplayed the new installer, and all other packages used the old installer. All installer worked as expected locally.