Use static caching to reduce lookups in import display

[eileenmcnaughton]

Overview

Use static caching to reduce lookups in import display

Before

When loading an import display the modifiySpec function is called once per editable field * the number of lines. As each field is set to editable this means the number of columns in the csv * the number of rows. Commonly the number of columns is large because an export from civicrm has a large number of columns and the default number of rows displayed is 25 - so in the api call that is cached here is called hundreds of times (at least) to render the view

After

The use of the static cache removes this point of repetitiveness - and makes sense IMHO but the getEditableInfo function remains extremely slow as this is small part of that function

Technical Details

I used static caching rather than metadata cache as the information is quick to load and that way we can do it once per job. If we use the cache then we get into how we clear it & wind up putting all the jobs in one cache - which risks being slow to serialize & unserialize

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗