Import minor adjustments - add getters, setters, flush, ability to export #29057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
colemanw
reviewed
Jan 21, 2024
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jan 26, 2024
Bug: T341902 Change-Id: I0613831af7e283210bee8c2ebc76193c5e70e1f5
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jan 31, 2024
…undraising/crm into deployment + b0f0dee CiviCRM 5.70-rc + ab90337 Port civicrm/civicrm-core#29057 + 1c810d9 Port civicrm/civicrm-core#29061 + 36554c2 Port civicrm/civicrm-core#29059 + d6acf5a Also update next_sched_contribution_date and cycle_day for for old paypal + 38ce06b Port civicrm/civicrm-core#29062 + c30f7e3 Fix failure to calculate donor_status 90 + 665f1b9 IDE formatting + 79b692c Apply IDE formatting for short-array syntax + 2f8e405 Use EntityTrait & createTestEntity creating contacts + 9b37027 Add test for unspecified contact ID bug + 6fa13ca Add missing use statement + 9b74cbc Set next_sched date when entering autoRescue + d649850 Fixes for recurring queue consumer and tests + ac3221b Add import_extensions + e286eef Add managed template for data axle import + 9f01676 Add failed recurring to fundraiseup imports + 5d9feb8 Pull in lastest 5.70rc updates + 96884f8 Fix recurring queue test + e60b161 Fix Deep Lapsed to 2-5 financial years Change-Id: I86f92e6f5bc68debe16924aeaf4110c3eff39ba9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Import minor adjustments - add getters, setters, flush, ability to export
Before
The statuses & limit properties are private on the parent class but would reasonably be accessing by the children, hence getters & setters added. Hard to convert import configs to code
After
Getters & setters & import added
Technical Details
Although I'm attempting to add this from a child class in an extension I don't see the signature for external integrations as 'settled' yet & want to try to lock that down with comments / documentation once I have fully worked through it
Comments