-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchKit - In-place edit without refreshing results #27105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
84411ea
to
aa1287f
Compare
@MegaphoneJon aside from entityRef fields this is ready for review. |
I reviewed it and pushed it to a client for further review, but I haven't heard back. I'll check in with him tomorrow. |
Before: .done() method only works with jQuery object After: .then() method works with both
aa1287f
to
5172c3b
Compare
My client hasn't had a chance to review this - but my |
Merging based on @MegaphoneJon r-run |
colemanw
added a commit
to colemanw/civicrm-core
that referenced
this pull request
Sep 6, 2023
Followup to civicrm#27105 this uses native angular service instead of jQuery-based function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This speeds up the process of in-place-editing on a SearchKit display.
Before
Modifying a field results in several seconds' wait (if you have enough columns).
After
Instead of waiting for the table to reload, you can continue editing other fields immediately and saving happens in the background.
Added the little green status indicator in the top-right corner to show save progress.
Technical Details
This required a bit of reinventing-the-wheel because display values are usually formatted server-side. I had to add a function to do client-side formatting, and the result is... comparable. Dates don't come out exactly the same way due to differences between Civi's js and php implementations of date formatting. Selects, radios, textfields, multi-selects, booleans and money fields all work ok. EntityRefs are still todo, because I noticed another issue with those.