[Draft] don't reload searchkit on edit #27098
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When an inline edit field in SearchKit is modified, the entire query is reloaded. This aims to make the UI snappier.
To test, you can create any SK query with in-line edit fields - though the difference will be far more pronounced with more columns/results. You can see in the Network tab that the call to
SearchDisplay.run
doesn't occur.Before
Modifying a field results in several seconds' wait (if you have enough columns).
After
Super-fast.
Comments
This successfully updates the database, and if you go to edit again, your value will be present. But the new value doesn't display on screen post-save, even though my AngularJS plugin says the scope is updated.
I've been trying to learn AngularJS but I've spent more hours than I'd like to say trying to finish this - any pointers on this last part would be helpful.