dev/core#4480 Fix MailSettings add path

[larssandergreen]

Overview

#26733 and prior PRs changed the path for adding a new Mail Account from civicrm/admin/mailSettings?action=add&reset=1 using CRM_Admin_Page_MailSettings to civicrm/admin/mailSettings/edit?action=add&reset=1 using CRM_Admin_Form_MailSettings. The Add Mail Account button URL was not changed, so Add was still using the Page class while Edit was using the Form class with the result that the help didn't work while editing, but did work while adding.

Before

Inconsistent paths / classes so help didn't work.

After

Consistent paths / classes, no more including the Form in the Page.

Also, I noticed that oauth-client needed the same path update. This seems to be the only other use of this path in universe.

Comments

Have not tested the oauth-client change as I'm not familiar with this.

The regression is in 5.64, but this seems pretty minor, so might be good enough just to fix in 5.65.

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4480

[larssandergreen]

jenkins, test this please

[aydun]

Looks good - thanks for fixing.