AdminUI: Convert Mail Accounts page civicrm/admin/mailSettings #26733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CiviCRM! ❤️ Here's what's next:
|
colemanw
reviewed
Jul 4, 2023
| <desc>List email accounts.</desc> | ||
| <access_arguments>access CiviCRM,access CiviMail</access_arguments> | ||
| <adminGroup>CiviMail</adminGroup> | ||
| <weight>420</weight> |
There was a problem hiding this comment.
The diff is weird, you're not actually adding these items here... but OTOH I don't think they belong in the new /edit path, I think you can strip the <desc> and <adminGroup> tags from that one.
colemanw
reviewed
Jul 4, 2023
CRM/Mailing/xml/Menu/Mailing.xml
Outdated
| <item> | ||
| <path>civicrm/admin/mailSettings/edit</path> | ||
| <title>Mail Accounts</title> | ||
| <page_callback>CRM_Admin_Page_MailSettings</page_callback> |
There was a problem hiding this comment.
Can this point directly to CRM_Admin_Form_MailSettings - I think that ought to work and it's a nice step toward detangling the form from the page.
colemanw
reviewed
Jul 4, 2023
| 'dataType' => 'Boolean', | ||
| 'label' => E::ts('Used For'), | ||
| 'sortable' => TRUE, | ||
| 'rewrite' => "{if '[is_default]' == 'Yes'}" . E::ts("Bounce Processing <strong>(Default)</strong>") . "{else}" . E::ts("Email-to-Activity") . "{/if}", |
There was a problem hiding this comment.
Oof, this will only work in English. This is another reason we need access to raw values in tokens.
|
A couple style-check issues: |
aydun
force-pushed
the
adminui_mailsettings
branch
from
0e297e0 to
c95f925
Compare
Make MailSettings available to SearchKit
|
Thanks @aydun |
|
thanks @colemanw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add Mail Accounts page to AdminUI
Before
Old
After
New
Make MailSettings available to SearchKit
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note