Update a few references to list()
#26023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update a few references to
list()Before
After
[, $removed, $notRemoved]Technical Details
After finding myself in a fight with
phpcson #26002 I figured it made more sense to try to win with a recent version of code - which led me to @michaelmcandrew's efforts - https://packagist.org/packages/michaelmcandrew/civicrm-coding-standards#1.1.1I'm still tinkering with those but they are throwing up this
listconstruct - which we have been replacing anyway so I figured I'd put up a few fixesComments