Declare strict types in CiviUnitTestCase

[eileenmcnaughton]

Overview

Declare strict types in CiviUnitTestCase

Before

Strict types not declared in unit tests

After

Strict types declared on main base class

Technical Details

My reading of
https://www.phptutorial.net/php-tutorial/php-strict_types/

is that

1. declaring strict type declarations in tests might help us pick up bugs we would otherwise miss and
2. I believe that we would have to declare it in EVERY test file, rather than it inheritting to child classes

Comments

Let's see what this throws up...

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I'll figure out the style once I see how the rest plays out...

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[colemanw]

@eileenmcnaughton I'm really surprised that passed. Are we sure it actually worked?
Does strict_types prevent you from passing a numeric string to a function that requires a number? Like

function foo(int $id) {}`
foo('123');

Because we do that a lot.

[eileenmcnaughton]

@colemanw the first time I tried this it failed on passing NULL to regex - but note I think it only works on functions called directly from the class in question & I did a pass a while back on that

[eileenmcnaughton]

@colemanw ALSO I think type hinting on numbers will co-erce numeric to int (at least in some php versions)