Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Merge custom fields] Copy complex function into merger class, ready to disentangle as little shared code is really used #25219

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 26, 2022

Overview

Copy complext function into merger class, ready to disentangle as little shared code is really used

Before

Complex getTree function called - code does much work before & after to prepare to call this but as a shared function it can't be rationalised

After

Merger code has it's own copy - so we can clean up

Technical Details

This is VERY heavily tested

I had to make one function temporarily public but commented 'beware' and will try to change that as I clean it up

Comments

@civibot
Copy link

civibot bot commented Dec 26, 2022

(Standard links)

@civibot civibot bot added the master label Dec 26, 2022
@eileenmcnaughton eileenmcnaughton changed the title Copy complext function into merger class, ready to disentangle as little shared code is really used Copy complex function into merger class, ready to disentangle as little shared code is really used Dec 26, 2022
Copy complext function into merger class, ready to disentangle as
little shared code is really used
@eileenmcnaughton eileenmcnaughton changed the title Copy complex function into merger class, ready to disentangle as little shared code is really used [REF] [Merge custom fields] Copy complex function into merger class, ready to disentangle as little shared code is really used Dec 27, 2022
@colemanw colemanw merged commit d8da885 into civicrm:master Jan 10, 2023
@eileenmcnaughton eileenmcnaughton deleted the cust_ed branch January 10, 2023 21:53
@eileenmcnaughton
Copy link
Contributor Author

thanks @colemanw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants