[REF] [Merge custom fields] Copy complex function into merger class, ready to disentangle as little shared code is really used #25219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Copy complext function into merger class, ready to disentangle as little shared code is really used
Before
Complex
getTree
function called - code does much work before & after to prepare to call this but as a shared function it can't be rationalisedAfter
Merger code has it's own copy - so we can clean up
Technical Details
This is VERY heavily tested
I had to make one function temporarily public but commented 'beware' and will try to change that as I clean it up
Comments