Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom data when creating smart group #23312

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

awestuk
Copy link
Contributor

@awestuk awestuk commented Apr 27, 2022

Overview

Adds group custom fields when creating a new smart group from search action Group -> Create Smart Group

Before

image

After

image

Technical Details

Mostly just copies #21716.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Apr 27, 2022

(Standard links)

@civibot civibot bot added the master label Apr 27, 2022
@mattwire
Copy link
Contributor

This seems ok to me. I guess @colemanw may want to take a quick look in case there are any better ways of doing some of this now?

@seamuslee001
Copy link
Contributor

Jenkins ok to test

@yashodha
Copy link
Contributor

@awestuk You might want to squash your commits. Thanks!

@aydun
Copy link
Contributor

aydun commented Jun 1, 2023

Test this please

@mlutfy
Copy link
Member

mlutfy commented Aug 18, 2023

I think CRM_Core_Form_EntityFormTrait is a way to simplify Entity forms that have custom fields and avoid copy-paste, but since it's a small change and makes it consistent with #21716, I am inclined to merge.

@mlutfy mlutfy added the merge ready PR will be merged after a few days if there are no objections label Aug 18, 2023
@colemanw
Copy link
Member

Looks good to me as well

@colemanw colemanw merged commit e6b439e into civicrm:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants