dev/core#2885 Expose Custom Fields on the New Group form of the Add To Group task

[jaapjansma]

Overview

Adds custom fields to the screen when creating a new group from the search action Group - Add contacts to group.

Before

No custom fields are visible. See screenshot below.

After

Custom fields are visible. See screenshot below.

Comments

See https://lab.civicrm.org/dev/core/-/issues/2885

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks. Makes sense and runs ok.

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
  • [r-maint] It's forms but it might be doable to at least test that postProcess recognizes the custom fields
    • Something like this might work - need to adjust a bit:

    $form = $this->getFormObject('CRM_Contact_Form_Task_AddToGroup', [
      'title' => 'group1',
      ... etc ...
      'custom_7' => 'abc',  // need to create this field first
    ]);
    $form->postProcess();
    $group = $this->callAPISuccess('Group', 'getsingle', [
      'title' => 'group1',
      'return' => ['custom_7'],
    ]);
    $this->assertEquals('abc', $group['custom_7']);

  • [r-test] PASS

[jaapjansma]

I have added a unit test. For the task add to group no test existed so I have added a test for the adding to an existing group and for adding to a new group with a custom field.

[colemanw]

@jaapjansma can you please squash your 3 commits?

[jaapjansma]

@colemanw I have squashed my commits into one.

[colemanw]

Looks good :)

[demeritcowboy]

Thanks @jaapjansma 👍