Remove call to getTokenDetails #21972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This is tested vi CRM_Event_Form_Task_BatchTest::testSubmitCancel
eileenmcnaughton
force-pushed
the
gettok
branch
from
4b599bf to
943c6d0
Compare
This revises a very recent commit that touches `static $contactDetails` cache. Imagine you have two calls to `transitionParticipants()` which involve different-but-overlapping sets: * First invocation involves Alice and Bob * Second invocation involves Bob and Carol The first invocation loads Alice and Bob into `$contactDetails`. The second invocation identifies Carol as missing. We need to load Carol. Here's the change: * Before: Carol overwrites Bob in `$contactDetails`. Bob goes missing. * After: Alice, Bob, and Carol all exist in `$contactDetails`.
|
I confirmed that the test does give some coverage over this. (At least, you hack the code, you can break the test. 😃 ) Additionally, there is generally a fair amount of coverage over tokens and CiviEvent. Also, I poked into the function that receives the new I think there was a small edge-case bug in the cache maintenance. Pushed up a simple fix. Merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove call to getTokenDetails
Before
Call to
getTokenDetailscalls the legacy token hook - but the results are not usedAfter
SImple api call to retrieve minimum required details
Technical Details
This is tested vi CRM_Event_Form_Task_BatchTest::testSubmitCancel
Comments
Note that after this
getTokenDetailsis still called from the Job.update_greetings - which ALSO calls tokenProcessor and from legacy mailings. Hence there is no reason to implementhookTokenValuesanymore (although flexmailer should be required by extensions that offer tokens)