Remove call to getTokenDetails

This is tested vi CRM_Event_Form_Task_BatchTest::testSubmitCancel
civicrm · Nov 4, 2021 · 943c6d0 · 943c6d0
1 parent c158e60
commit 943c6d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/CRM/Event/BAO/Participant.php b/CRM/Event/BAO/Participant.php
@@ -1236,15 +1236,7 @@ public static function transitionParticipants(
 
     //get all required contacts detail.
     if (!empty($contactIds)) {
-      // get the contact details.
-      list($currentContactDetails) = CRM_Utils_Token::getTokenDetails($contactIds, NULL,
-        FALSE, FALSE, NULL,
-        [],
-        'CRM_Event_BAO_Participant'
-      );
-      foreach ($currentContactDetails as $contactId => $contactValues) {
-        $contactDetails[$contactId] = $contactValues;
-      }
+      $contactDetails = civicrm_api3('Contact', 'get', ['id' => ['IN' => $contactIds, 'return' => 'display_name']])['values'];
     }
 
     //get all required events detail.
@@ -1312,7 +1304,7 @@ public static function transitionParticipants(
             $mail = self::sendTransitionParticipantMail($additionalId,
               $participantDetails[$additionalId],
               $eventDetails[$participantDetails[$additionalId]['event_id']],
-              $contactDetails[$participantDetails[$additionalId]['contact_id']],
+              NULL,
               $emailType
             );
 
@@ -1331,7 +1323,7 @@ public static function transitionParticipants(
         $mail = self::sendTransitionParticipantMail($participantId,
           $participantValues,
           $eventDetails[$participantValues['event_id']],
-          $contactDetails[$participantValues['contact_id']],
+          NULL,
           $emailType
         );
 

diff --git a/CRM/Utils/Token.php b/CRM/Utils/Token.php
@@ -1134,6 +1134,8 @@ public static function getReturnProperties(&$string) {
   }
 
   /**
+   * Do not use this function.
+   *
    * Gives required details of contacts in an indexed array format so we
    * can iterate in a nice loop and do token evaluation
    *
@@ -1152,6 +1154,8 @@ public static function getReturnProperties(&$string) {
    * @param int|null $jobID
    *   The mailing list jobID - this is a legacy param.
    *
+   * @deprecated
+   *
    * @return array - e.g [[1 => ['first_name' => 'bob'...], 34 => ['first_name' => 'fred'...]]]
    */
   public static function getTokenDetails(
@@ -1164,7 +1168,6 @@ public static function getTokenDetails(
     $className = NULL,
     $jobID = NULL
   ) {
-
     $params = [];
     foreach ($contactIDs as $contactID) {
       $params[] = [